netdev - Re: [BUG] net_cls: Panic occured when net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090530132047.GD3166@ami.dom.local>
Date:	Sat, 30 May 2009 15:20:47 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	jamal <hadi@...erus.ca>
Cc:	Minoru Usui <mi.usui@...il.com>,
	Minoru Usui <usui@....nes.nec.co.jp>, netdev@...r.kernel.org,
	containers@...ts.linux-foundation.org
Subject: Re: [BUG] net_cls: Panic occured when net_cls subsystem use

On Sat, May 30, 2009 at 09:03:48AM -0400, jamal wrote:
> On Sat, 2009-05-30 at 14:45 +0200, Jarek Poplawski wrote:
> > On Sat, May 30, 2009 at 08:31:23AM -0400, jamal wrote:
...
> > > The ops is caused by the code fixed in the patch - did i miss something?
> > 
> > IMHO it could be fixed "old way" in cls_group code too.
> 
> Is the code oopsing in cls_group? It didnt seem to be so to me, and
> yes cls_group is quarky in its practise (but thats a separate issue)
> and even if it did oops in cls_group - this change above is a memory
> leak and needs to be fixed in -stable. 

Yes it oopses in cls_cgroup_classify(). Here is the first report:
http://permalink.gmane.org/gmane.linux.network/128593

We add/link unconfigured tp, but it could be destroyed later, so I
wouldn't call this a memory leak.

Cheers,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html