netdev - Re: [BUG] net_cls: Panic occured when net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090531081213.GC2756@ami.dom.local>
Date:	Sun, 31 May 2009 10:12:13 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	jamal <hadi@...erus.ca>
Cc:	Minoru Usui <usui@....nes.nec.co.jp>, netdev@...r.kernel.org,
	containers@...ts.linux-foundation.org
Subject: Re: [BUG] net_cls: Panic occured when net_cls subsystem use

On Sat, May 30, 2009 at 07:50:18AM -0400, jamal wrote:
> On Sat, 2009-05-30 at 00:59 +0200, Jarek Poplawski wrote:
>   
> > ...
> >         } else {
> >                 switch (n->nlmsg_type) {
> >                 case RTM_NEWTFILTER:
> >                         err = -EEXIST;
> >                         if (n->nlmsg_flags & NLM_F_EXCL)
> >                                 goto errout;
> >                         break;
> > 
> > Probably this case needs tcf_destroy() too.
> 
> No - that if stmnt will fail if this is a new filter being
> created.

If somebody runs tc add filter with a new priority but existing handle
a newly created (and not linked now) tc would be handled with goto
errout and would leak, I guess.

Cheers,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html