netdev - Re: [BUG] net_cls: Panic occured when net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090531195557.GA2777@ami.dom.local>
Date:	Sun, 31 May 2009 21:55:57 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	jamal <hadi@...erus.ca>
Cc:	Minoru Usui <usui@....nes.nec.co.jp>, netdev@...r.kernel.org,
	containers@...ts.linux-foundation.org
Subject: Re: [BUG] net_cls: Panic occured when net_cls subsystem use

On Sun, May 31, 2009 at 09:24:53AM -0400, jamal wrote:
> On Sun, 2009-05-31 at 10:12 +0200, Jarek Poplawski wrote:
> 
> > If somebody runs tc add filter with a new priority but existing handle
> > a newly created (and not linked now) tc would be handled with goto
> > errout and would leak, I guess.
> 
> This would imply the classifier is buggy. I will stare at the different
> classifier - and if any exhibits such traits it needs to be fixed
> 
> > The change (in the two spots) is:
> > > +               if (n->nlmsg_type == RTM_NEWTFILTER &&
> > > +                   (n->nlmsg_flags&(NLM_F_CREATE|NLM_F_EXCL))) {
> > > 
> > 
> > Sorry, but I don't think this change is enough; tc filter replace
> > with only this (n->nlmsg_type == RTM_NEWTFILTER &&
> > (n->nlmsg_flags&(NLM_F_CREATE))) can get here with an "old" tp
> > and will relink it or destroy depending on the ->change() return.
> > 
> 
> Excellent point - there could be buggy user space apps that will do
> that. Minoru change the check to:
> 
> +               if (n->nlmsg_type == RTM_NEWTFILTER &&
> +                   (n->nlmsg_flags&NLM_F_CREATE &&
> +                    n->nlmsg_flags&NLM_F_EXCL)) {


But then, there could be "tc filter replace" with only this
(n->nlmsg_type == RTM_NEWTFILTER && (n->nlmsg_flags&(NLM_F_CREATE)))
which can't get here with a newly created tp, I guess.

Cheers,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html