lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 01 Jun 2009 03:04:34 -0700 (PDT) From: David Miller <davem@...emloft.net> To: tilman@...p.cc Cc: karsten-keil@...nline.de, isdn4linux@...tserv.isdn4linux.de, i4ldeveloper@...tserv.isdn4linux.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/3] isdn: patches for 2.6.31 From: Tilman Schmidt <tilman@...p.cc> Date: Sun, 31 May 2009 01:32:04 +0200 (CEST) > I would like to propose the following three patches to the Kernel CAPI > subsystem for inclusion in kernel release 2.6.31. > The first one was proposed four weeks ago and so far hasn't met any > protests. > The second one is a rather trivial bugfix and documentation improvement. > The third one just adds a few new insights about the workings of the > CAPI subsystem to the Documentation file, INTERFACE.CAPI. I'm not applying this patch series. Especially I dislike the second patch. First problem in the second patch. You're doing two things at once. You're adding function documentation and also adding a NULL pointer check. Second problem, the NULL pointer check is gratuitous. Document that the 'm' member has to be non-NULL and leave the check out. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists