lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20090531.215140.214511212.davem@davemloft.net>
Date:	Sun, 31 May 2009 21:51:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jie.yang@...eros.com
Cc:	pyunyh@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next]atl1c: fix spelling error

From: <jie.yang@...eros.com>
Date: Mon, 1 Jun 2009 10:07:58 +0800

> Fix spelling error
> 
> Signed-off-by: Jie Yang <jie.yang@...eros.com>
 ...
> @@ -1115,7 +1115,7 @@ static int atl1c_stop_mac(struct atl1c_hw *hw)
>  
>  	AT_READ_REG(hw, REG_TXQ_CTRL, &data);
>  	data &= ~TXQ_CTRL_EN;
> -	AT_WRITE_REG(hw, REG_TWSI_CTRL, data);
> +	AT_WRITE_REG(hw, REG_TXQ_CTRL, data);
>  
>  	for (timeout = 0; timeout < AT_HW_MAX_IDLE_DELAY; timeout++) {
>  		AT_READ_REG(hw, REG_IDLE_STATUS, &data);

A spelling error would occur on human language text.

That's not what this is.

The code is referring to the wrong register, so it's a bug not a
spelling error.

Please fix your commit message and resubmit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ