netdev - Re: [PATCH] e1000e: io_error_detected callback should return PCI_ERS_RESULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090601.182651.227000394.davem@davemloft.net>
Date:	Mon, 01 Jun 2009 18:26:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	mmlnx@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] e1000e: io_error_detected callback should return
 PCI_ERS_RESULT_DISCONNECT on permanent failure

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 1 Jun 2009 16:43:39 -0700

> On Fri, May 29, 2009 at 2:16 PM, Mike Mason <mmlnx@...ibm.com> wrote:
>> PCI drivers that implement the io_error_detected callback
>> should return PCI_ERS_RESULT_DISCONNECT if the state
>> passed in is pci_channel_io_perm_failure.  This state is not checked in many
>> of the network drivers.
>>
>> This patch fixes the omission in the e1000e driver.
>>
>> Signed-off-by: Mike Mason <mmlnx@...ibm.com>
>> --- a/drivers/net/e1000e/netdev.c       2009-05-23 14:47:00.000000000 -0700
>> +++ b/drivers/net/e1000e/netdev.c       2009-05-29 13:43:24.000000000 -0700
>> @@ -4616,6 +4616,9 @@ static pci_ers_result_t e1000_io_error_d
>>
>>        netif_device_detach(netdev);
>>
>> +       if (state == pci_channel_io_perm_failure)
>> +               return PCI_ERS_RESULT_DISCONNECT;
>> +
>>        if (netif_running(netdev))
>>                e1000e_down(adapter);
>>        pci_disable_device(pdev);
>>
>> --
> 
> Looks good.
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Jeff, can you simply queue this up into the next batch of Intel
driver bits you send to me?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html