netdev - Re: [PATCH] Fix a race between sky2_down and sky2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A24C6DE.1040301@ring3k.org>
Date:	Tue, 02 Jun 2009 15:29:50 +0900
From:	Mike McCormack <mikem@...g3k.org>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] Fix a race between sky2_down and sky2_poll.

Stephen Hemminger wrote:

>> -	/* Make sure no packets are pending */
>> -	napi_synchronize(&hw->napi);

> Down is also used during suspend/resume and changing MTU so this needs
> more inspection.

Could it be that the real problem is with the non-SMP case for 
napi_synchronize()?  The comment in include/linux/netdevice.h claims 
that napi_synchronize() "Waits till any outstanding processing 
completes..." but the implementation for non-SMP is just a barrier()...

Mike

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html