netdev - Re: [PATCH 1/3] sis190: add new phy found on asus F5 series laptops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090602211810.GA26871@electric-eye.fr.zoreil.com>
Date:	Tue, 2 Jun 2009 23:18:10 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Riccardo Ghetta <birrachiara@....it>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] sis190: add new phy found on asus F5 series laptops

Riccardo Ghetta <birrachiara@....it> :
> Signed-off-by: Riccardo Ghetta <birrachiara@....it>
> ---
>  drivers/net/sis190.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
> index 55ccd51..3d4542e 100644
> --- a/drivers/net/sis190.c
> +++ b/drivers/net/sis190.c
> @@ -317,6 +317,7 @@ static struct mii_chip_info {
>          unsigned int type;
>  	u32 feature;
>  } mii_chip_table[] = {
> +	{ "Atheros PHY ?",        { 0x004d, 0xd010 }, LAN, 0 },
>  	{ "Atheros PHY AR8012",   { 0x004d, 0xd020 }, LAN, 0 },
>  	{ "Broadcom PHY BCM5461", { 0x0020, 0x60c0 }, LAN, F_PHY_BCM5461 },
>  	{ "Broadcom PHY AC131",   { 0x0143, 0xbc70 }, LAN, 0 },

Please be more specific with the identifier of your laptop. Afaiu some
laptops in the F5 series include network components from Realtek. It could
be confusing.

You can remove the question mark. If we can only tell that the phy comes
from Atheros, so be it.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html