netdev - Re: [PATCH 3/3] sis190: better message on unknown PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090602214335.GA24637@electric-eye.fr.zoreil.com>
Date:	Tue, 2 Jun 2009 23:43:35 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Riccardo Ghetta <birrachiara@....it>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] sis190: better message on unknown PHY

Riccardo Ghetta <birrachiara@....it> :
[...]
> diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
> index 8322e28..a69f3d2 100644
> --- a/drivers/net/sis190.c
> +++ b/drivers/net/sis190.c
[...]
> @@ -1329,12 +1329,15 @@ static void sis190_init_phy(struct net_device *dev, struct sis190_private *tp,
>  			((mii_status & (BMSR_100FULL | BMSR_100HALF)) ?
>  				LAN : HOME) : p->type;
>  		tp->features |= p->feature;
> -	} else
> +		net_probe(tp, KERN_INFO "%s: %s transceiver at address %d.\n",
> +			pci_name(tp->pci_dev), p->name, phy_id);
> +	} else {
>  		phy->type = UNKNOWN;
> -
> -	net_probe(tp, KERN_INFO "%s: %s transceiver at address %d.\n",
> -		  pci_name(tp->pci_dev),
> -		  (phy->type == UNKNOWN) ? "Unknown PHY" : p->name, phy_id);
> +		net_probe(tp, KERN_INFO
> +			"%s: unknown PHY 0x%x:0x%x transceiver at address %d\n",
                                         ^^^^ ^^^^ 0x%04x:0x%04x ?
> +			pci_name(tp->pci_dev),
> +			phy->id[0], (phy->id[1] & 0xfff0), phy_id);
> +	}
>  }

Please make it the first in the series.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html