netdev - Re: [PATCH 8/8] mlx4_en: Updated driver version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090602.023611.243300436.davem@davemloft.net>
Date:	Tue, 02 Jun 2009 02:36:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	netdev@...r.kernel.org, tziporet@...lanox.co.il
Subject: Re: [PATCH 8/8] mlx4_en: Updated driver version

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Tue, 02 Jun 2009 12:29:42 +0300

> +#define DRV_VERSION	"1.4.1.1

You checked in this commit to your tree WITHOUT EVEN BUILD TESTING IT!

drivers/net/mlx4/en_main.c:48: error: missing terminating " character
drivers/net/mlx4/en_main.c:48: error: expected ‘,’ or ‘;’ before string constant
drivers/net/mlx4/en_main.c:52: error: missing terminating " character
drivers/net/mlx4/en_main.c:52: error: expected ‘,’ or ‘;’ before string constant

I fixed this up in my tree but I'm really pissed that you submitted
patches to me that YOU DID NOT EVEN BUILD TEST.