netdev - Re: [PATCH 2/3] sis190: fix gigabit negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A2614F4.9050304@tin.it>
Date:	Wed, 03 Jun 2009 08:15:16 +0200
From:	rgh <birrachiara@....it>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] sis190: fix gigabit negotiation

Francois Romieu wrote:
> Riccardo Ghetta <birrachiara@....it> :
>> Fixes an initialization error; the chip negotiates gigabit, but
>> the driver mistakenly handled it as 100Mb.
> 
> Did you draw some inspiration from SiS own driver ? If so it would
> deserve to be quoted.
> 
Yes, I looked at both sis and forcedeth drivers. I'll quote both.

> val has been read from the LPA register.
> 
> s/ADVERTISE_NPAGE/LPA_NPAGE/ ?
Uhu, yes, sorry.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html