netdev - Re: [PATCH] tun: virtio net is not compatible with LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906031652.56084.rusty@rustcorp.com.au>
Date:	Wed, 3 Jun 2009 16:52:55 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] tun: virtio net is not compatible with LRO

On Wed, 3 Jun 2009 02:53:35 pm Chris Wright wrote:
> The current failure mode for an LRO device bridged to a virtio device
> (common for KVM) is BUG().  Rather than crashing the host, we can at
> least limp along and give a warning.  lro_flush() will set gso_size,
> but no corresponding gso_type, unlike gro which will eventually call
> ->gro_complete and set up proper gso_type.

So, skb_is_gso() is true, but it's not actually a gso frame?

I know nothing about LRO, but that seems wrong.  If you bridge any other GSO 
device with an LRO device, does that do random things as well?

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html