netdev - Re: [PATCH iproute2] Re: HTB accuracy for high speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A264AE8.2050105@trash.net>
Date:	Wed, 03 Jun 2009 12:05:28 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	Antonio Almeida <vexwek@...il.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	netdev@...r.kernel.org, davem@...emloft.net, devik@....cz,
	Eric Dumazet <dada1@...mosbay.com>,
	Vladimir Ivashchenko <hazard@...ncoudi.com>
Subject: Re: [PATCH iproute2] Re: HTB accuracy for high speed

Patrick McHardy wrote:
> Jarek Poplawski wrote:
>> On Wed, Jun 03, 2009 at 09:53:11AM +0200, Patrick McHardy wrote:
>> ...
>>> The necessary changes are
>>> really trivial, all you need to do when changing the scaling factors
>>> is to increase SM_MASK and decrease ISM_MASK accordingly.
>>
>> OK, looks like it's really enough and I was confused with some
>> rounding, thanks Patrick.
> 
> Looks fine in principle, but considering your change to the generic
> scaling factors:
> 
>> -#define PSCHED_US2NS(x)            ((s64)(x) << 10)
>> -#define PSCHED_NS2US(x)            ((x) >> 10)
>> +#define PSCHED_US2NS(x)            ((s64)(x) << 6)
>> +#define PSCHED_NS2US(x)            ((x) >> 6)
> 
> PSCHED_SHIFT should be 4, right?


> -#define	SM_SHIFT	20
> -#define	ISM_SHIFT	18
> +#define	PSCHED_SHIFT	6	/* TODO: move to pkt_sched.h */
> +#define	SM_SHIFT	(30 - PSCHED_SHIFT)
> +#define	ISM_SHIFT	(8 + PSCHED_SHIFT)

Actually I'm confused, why the additional change of 10?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html