netdev - Re: [PATCH 2/2] forcedeth: Addition of new device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090603.145721.65051603.davem@davemloft.net>
Date:	Wed, 03 Jun 2009 14:57:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	aabdulla@...dia.com, manfred@...orfullife.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] forcedeth: Addition of new device id

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Wed, 3 Jun 2009 14:52:38 -0700

> On Wed, 03 Jun 2009 14:26:47 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
>> Andrew, we do not add new entries to pci_ids.h any more.
> 
> Lots of people are still changing it.

Not enough policing, that's all.  Even I let one slip in recently, but
that was an oversight rather than something I did on purpose. :-)

> I believe that the approach we've been taking is: if the driver
> presently uses pci_ids.h and you're adding a new ID then go for it.
> But new drivers should use a private site for the IDs.  And patches
> which switch old drivers from pci_ids over to a private site are
> approved of.

I think it's silly to let use continue even in those situations.  If
it's in a header file, it's so that it can (at least potentially) be
used in multiple places.  That is not the situation we are handling
here, such defines are always used in exactly one place, the driver ID
table.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html