[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20090603.212105.160757852.davem@davemloft.net>
Date: Wed, 03 Jun 2009 21:21:05 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: netdev@...r.kernel.org
Subject: Re: gso: Stop fraglists from escaping
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 4 Jun 2009 11:01:21 +1000
> gso: Stop fraglists from escaping
>
> As it stands skb fraglists can get past the check in dev_queue_xmit
> if the skb is marked as GSO. In particular, if the packet doesn't
> have the proper checksums for GSO, but can otherwise be handled by
> the underlying device, we will not perform the fraglist check on it
> at all.
>
> If the underlying device cannot handle fraglists, then this will
> break.
>
> The fix is as simple as moving the fraglist check from the device
> check into skb_gso_ok.
>
> This has caused crashes with Xen when used together with GRO which
> can generate GSO packets with fraglists.
>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
Applied to net-next-2.6, thanks Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists