[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090604114642.GA26217@rere.qmqm.pl>
Date: Thu, 4 Jun 2009 13:46:42 +0200
From: Michał Mirosław <mirq@...e.qmqm.pl>
To: Ayaz Abdulla <aabdulla@...dia.com>
Cc: Manfred Spraul <manfred@...orfullife.com>,
"David S. Miller" <davem@...emloft.net>,
Andrew Morton <akpm@...l.org>, nedev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/3] forcedeth: remove device id macros
Hello,
On Wed, Jun 03, 2009 at 09:05:17PM -0400, Ayaz Abdulla wrote:
> This patch removes the device id macros and instead uses the constants
> directly.
>
> The areas in which logic expressions where using the macros now instead
> use feature/workaround flags.
>
> No new functionality has been introduced in this patch, only clean up of
> flags and macros.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> --- old/drivers/net/forcedeth.c 2009-06-03 20:38:59.000000000 -0400
> +++ new/drivers/net/forcedeth.c 2009-06-03 20:39:02.000000000 -0400
[...]
> @@ -6158,7 +6140,8 @@
> for (i = 0;i <= np->register_size/sizeof(u32); i++)
> writel(np->saved_config_space[i], base+i*sizeof(u32));
>
> - pci_write_config_dword(pdev, NV_MSI_PRIV_OFFSET, NV_MSI_PRIV_VALUE);
> + if (np->driver_data & DEV_NEED_MSI_FIX)
> + pci_write_config_dword(pdev, NV_MSI_PRIV_OFFSET, NV_MSI_PRIV_VALUE);
>
> /* restore phy state, including autoneg */
> phy_init(dev);
This fragment actually changes logic despite patch description.
> @@ -6207,160 +6190,160 @@
>
> static struct pci_device_id pci_tbl[] = {
> { /* nForce Ethernet Controller */
> - PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_1),
> + PCI_DEVICE(0x10DE, 0x01C3),
> .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER,
> },
[cut]
The PCI device ID constants have probably no real meaning, but why also
remove vendor ID constants?
Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists