netdev - Re: [PATCH net-next 2/3] net: Fix memcpy_toiovecend() to use the right offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Jun 2009 00:13:21 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Sridhar Samudrala <sri@...ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] net: Fix memcpy_toiovecend() to use the
	right offset

On Fri, Jun 05, 2009 at 12:35:44PM -0700, Sridhar Samudrala wrote:
> Increment the iovec base by the offset passed in for the initial
> copy_to_user() in memcpy_to_iovecend().
> 
> Signed-off-by: Sridhar Samudrala <sri@...ibm.com>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> diff --git a/net/core/iovec.c b/net/core/iovec.c
> index 40a76ce..16ad45d 100644
> --- a/net/core/iovec.c
> +++ b/net/core/iovec.c
> @@ -112,9 +112,9 @@ int memcpy_toiovecend(const struct iovec *iov, unsigned char *kdata,
>  			continue;
>  		}
>  		copy = min_t(unsigned int, iov->iov_len - offset, len);
> -		offset = 0;
> -		if (copy_to_user(iov->iov_base, kdata, copy))
> +		if (copy_to_user(iov->iov_base + offset, kdata, copy))
>  			return -EFAULT;
> +		offset = 0;
>  		kdata += copy;
>  		len -= copy;
>  	}
> 
> 
> 

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html