netdev - Re: [PATCH net-next 1/4] IPv6: HW csum support for outgoing large UFO packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200906080936.55820.remi.denis-courmont@nokia.com>
Date:	Mon, 8 Jun 2009 09:36:55 +0300
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	ext Sridhar Samudrala <sri@...ibm.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"herbert.xu@...hat.com" <herbert.xu@...hat.com>,
	"rusty@...tcorp.com.au" <rusty@...tcorp.com.au>
Subject: Re: [PATCH net-next 1/4] IPv6: HW csum support for outgoing large UFO packets

On Saturday 06 June 2009 03:16:27 ext Sridhar Samudrala wrote:
> @@ -668,7 +709,14 @@ static int udp_v6_push_pending_frames(struct sock *sk)
>
>  	if (is_udplite)
>  		csum = udplite_csum_outgoing(sk, skb);
> -	 else
> +	 else if (sk->sk_no_check == UDP_CSUM_NOXMIT) {	/* UDP csum disabled */
> +		skb->ip_summed = CHECKSUM_NONE;
> +		goto send;

There is no such thing as disabled UDP in IPv6 (in *current* specs).

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html