netdev - Re: [PATCH net-next 1/3] net: Fix skb_copy_datagram_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090608.002851.249913253.davem@davemloft.net>
Date:	Mon, 08 Jun 2009 00:28:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	sri@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] net: Fix skb_copy_datagram_from_iovec()
 to pass the right offset

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Sun, 7 Jun 2009 00:25:33 +0300

> On Fri, Jun 05, 2009 at 12:35:40PM -0700, Sridhar Samudrala wrote:
>> I am working on enabling UFO between KVM guests using virtio-net and i have 
>> some patches that i got working with 2.6.30-rc8. When i wanted to try them
>> with net-next-2.6, i noticed that virtio-net is not working with that tree.
>> 
>> After some debugging, it turned out to be several bugs in the recent patches
>> to fix aio with tun driver, specifically the following 2 commits.
>> 
>> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=0a1ec07a67bd8b0033dace237249654d015efa21
>> http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=6f26c9a7555e5bcca3560919db9b852015077dae
>> 
>> 
>> Fix the call to memcpy_from_iovecend() in skb_copy_datagram_from_iovec
>> to pass the right iovec offset.
>> 
>> Signed-off-by: Sridhar Samudrala <sri@...ibm.com>
> 
> Yes, looks like the bugs were around GSO handling, I was probably
> testing without GSO at the time. I'll go try with GSO now. Thanks for
> fixing these!
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html