netdev - Re: [PATCH] e100: Fix napi_enable BUG_ON when recovering from EEH error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 08 Jun 2009 00:42:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	adetsch@...ibm.com
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH] e100: Fix napi_enable BUG_ON when recovering from EEH
 error

From: Andre Detsch <adetsch@...ibm.com>
Date: Fri, 5 Jun 2009 17:04:25 -0300

> BUG_ON(!test_bit(NAPI_STATE_SCHED, &n->state)) was being hit
> during e100 EEH recovery. The problem source was a napi_enable
> call being made during e100_io_error_detected. Napi should remain
> disabled after e100_down, and only be reenabled when the interface
> is recovered.
> 
> This patch also updates e100_io_error_detected in order to make
> it similar to the current versions of the error_detected callback
> in drivers such as e1000e and ixgbe.
> 
> Signed-off-by: Andre Detsch <adetsch@...ibm.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html