netdev - Re: [PATCH 2/3] sit: handle ICMPv4 for tunnels with no remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090608.024024.236334849.davem@davemloft.net>
Date:	Mon, 08 Jun 2009 02:40:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	contact@...chahlusiak.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] sit: handle ICMPv4 for tunnels with no remote

From: Sascha Hlusiak <contact@...chahlusiak.de>
Date: Sat,  6 Jun 2009 16:02:51 +0200

> Don't drop ICMPv4 packages, if tunnel has no remote endpoint, like
> 6to4 or isatap tunnels.
> 
> Also don't drop it if tunnel inherits ttl and icmp_time_exceeded.
> Don't really see the usecase here.
> 
> Signed-off-by: Sascha Hlusiak <contact@...chahlusiak.de>

You're going to have to describe this change a bit more.

What in the world is wrong with dropping an ICMP time exceeded if the
TTL in the template header is zero?  Someone wrote that code and had
some reason to put it there.   Until you know the reason or can prove
without a shadow of doubt that it's pointless, you can't just remove
it.

You other two changes need more verbose commit messages as well.
I can't tell what the point or benefit are of your changes.

So I'm dropping your patches until all of this is resolved, and
the commit messages are more verbose and explain why you're doing
all of these things.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html