netdev - Re: [PATCH net-next 2/4] udp: Handle large UFO packets from untrusted sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1244480687.18220.36.camel@w-sridhar.beaverton.ibm.com>
Date:	Mon, 08 Jun 2009 10:04:47 -0700
From:	Sridhar Samudrala <sri@...ibm.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kvm@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH net-next 2/4] udp: Handle large UFO packets from
 untrusted sources

On Mon, 2009-06-08 at 15:16 +1000, Herbert Xu wrote:
> On Fri, Jun 05, 2009 at 05:16:31PM -0700, Sridhar Samudrala wrote:
> >
> > +	/* Software UFO is not yet supported */
> > +	segs = ERR_PTR(-EPROTONOSUPPORT);
> 
> Hmm, we need to fill this in before you start using it for virt.
> After all, it's very difficult for the guest to know whether the
> output device on the host is going to be able to do UFO or not.

OK. Can we use skb_segment() to do IP fragmentation of UDP packets?
Or does it only support TCP segementation?
The function itself looks protocol independent and if it is simply
splitting large skb into a list of mtu sized skb's, can we fixup the
ip header differently for UDP packets(id and frag_off) in inet_gso_segment
and ipv6_gso_segment?


Thanks
Sridhar

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html