netdev - Re: [RFC vlan 03/03]: propagate transmission state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A2E8FC2.2030100@trash.net>
Date:	Tue, 09 Jun 2009 18:37:22 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: [RFC vlan 03/03]: propagate transmission state

Eric Dumazet wrote:
> Patrick McHardy a écrit :
>>  static int vlan_dev_hwaccel_hard_start_xmit(struct sk_buff *skb,
>>  					    struct net_device *dev)
>>  {
>>  	struct netdev_queue *txq = netdev_get_tx_queue(dev, 0);
>> +	unsigned int len;
>>  	u16 vlan_tci;
>> +	int err;
>>  
>>  	vlan_tci = vlan_dev_info(dev)->vlan_id;
>>  	vlan_tci |= vlan_dev_get_egress_qos_mask(dev, skb);
>> @@ -339,8 +347,15 @@ static int vlan_dev_hwaccel_hard_start_xmit(struct sk_buff *skb,
>>  	txq->tx_bytes += skb->len;
> 
> It seems you forgot to delete previous txq->tx_bytes += skb->len; && txq->tx_packets++; ?

Indeed, thanks, I've fixed it in my tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html