netdev - Re: error handling for dev_mc_sync (__dev_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Jun 2009 19:19:50 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: error handling for dev_mc_sync (__dev_addr_add)

On Tue, 2009-06-09 at 19:10 +0200, Patrick McHardy wrote:

> > ----- >% -----
> > @ ndomatch @
> > identifier ndo, sml;
> > @@
> > struct net_device_ops ndo = {
> > .ndo_set_multicast_list = sml,
> > };
> > @forall@
> > identifier dev;
> > identifier ndomatch.sml;
> > @@
> > void sml(struct net_device *dev)
> 
> - void
> + int

Indeed.

> > {
> > ...
> > -return;
> > +return 0;
> > ...
> > }
> > ----- %< -----
> > 
> > Haven't really tested it though but it seems to do the correct thing for
> > all drivers I looked at.
> 
> In case this also adds a return statement at the end if none is
> there already, it looks fine.

Yes, it does. "All" that remains to be done then is to actually fix the
few users of dev_mc_sync(), and the callers, but that's the real work :)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)