netdev - Re: [PATCH 11/15]: netfilter: Use frag list abstraction interfaces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0906092220430.30827@ask.diku.dk>
Date:	Tue, 9 Jun 2009 22:23:52 +0200 (CEST)
From:	Jesper Dangaard Brouer <hawk@...u.dk>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 11/15]: netfilter: Use frag list abstraction interfaces.


On Tue, 9 Jun 2009, David Miller wrote:

> --- a/net/ipv4/netfilter/nf_nat_proto_sctp.c
> +++ b/net/ipv4/netfilter/nf_nat_proto_sctp.c
>
> @@ -57,8 +58,8 @@ sctp_manip_pkt(struct sk_buff *skb,
> 	}
>
> 	crc32 = sctp_start_cksum((u8 *)hdr, skb_headlen(skb) - hdroff);
> -	for (skb = skb_shinfo(skb)->frag_list; skb; skb = skb->next)
> -		crc32 = sctp_update_cksum((u8 *)skb->data, skb_headlen(skb),
> +	skb_walk_frags(skb, frag);

Think there is a semi-colon too much here, as skb_walk_frags expand to a 
for-loop statement, Right?

> +		crc32 = sctp_update_cksum((u8 *)frag->data, skb_headlen(frag),
> 					  crc32);
> 	crc32 = sctp_end_cksum(crc32);
> 	hdr->checksum = crc32;

Cheers,
   Jesper Brouer

--
-------------------------------------------------------------------
MSc. Master of Computer Science
Dept. of Computer Science, University of Copenhagen
Author of http://www.adsl-optimizer.dk
-------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html