netdev - Re: IPoIB: Fix multicast packet drops before join is complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090609.174504.114047526.davem@davemloft.net>
Date:	Tue, 09 Jun 2009 17:45:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rdreier@...co.com
Cc:	cl@...ux-foundation.org, netdev@...r.kernel.org,
	yosefe@...taire.COM
Subject: Re: IPoIB: Fix multicast packet drops before join is complete

From: Roland Dreier <rdreier@...co.com>
Date: Tue, 09 Jun 2009 13:52:45 -0700

> 
>  > > Maybe we need a different approach but (since we are at the point of
>  > > talking about categorical fundamentally wrong statements) its
>  > > fundamentally wrong if the IPoIB layer works differently from a regular
>  > > Ethernet NIC. They should work in the same way.
>  > 
>  > This I agree on.  When a multicast group is joined, the IPoIB layer
>  > should block in some way until the subscription is fully available
>  > for use.
> 
> Not sure I understand.  What do you mean by block?  It is quite possible
> that a single multicast group is waiting to be joined, while other
> multicast groups and unicast traffic can be sent with no problem.  So
> stopping the whole device queue and blocking everything doesn't seem
> appropriate.

Block the process joining the multicast group, not the entire
interface.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html