netdev - Re: [PATCH] mlx4_en: added pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090611.030527.14497101.davem@davemloft.net>
Date:	Thu, 11 Jun 2009 03:05:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	netdev@...r.kernel.org, tziporet@...lanox.co.il
Subject: Re: [PATCH] mlx4_en: added pci_device_id table

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Tue, 09 Jun 2009 15:53:47 +0300

> This is required to ensure that mlx4_en module loads on boot when
> there are ConnectX devices installed.
> The driver is compound from two modules: mlx4_core, the low level module
> and mlx4_en. Currently mlx4_core is the only module that is loaded on boot,
> this is not enough to enable the ConnectX Ethernet interfaces.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

This is pretty ugly.

Two modules with the same exact module ID table smells like bad
design.  I see no harm in you combining all of this code into one
final module object.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html