netdev - Re: virtio-net header alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090611.053930.255217615.davem@davemloft.net>
Date:	Thu, 11 Jun 2009 05:39:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	markmc@...hat.com, rusty@...tcorp.com.au, kudinskas@...ibm.com,
	aliguori@...ux.vnet.ibm.com, pablo@...ibm.com,
	netdev@...r.kernel.org
Subject: Re: virtio-net header alignment

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 10 Jun 2009 15:12:27 +1000

> On Mon, May 25, 2009 at 05:17:03PM +0100, Mark McLoughlin wrote:
>> 
>> Perhaps; would padding struct virtio_net_hdr_mrg_rxbuf have avoided it?
>> 
>> Cc-ing Herbert, he initially wrote the guest side of this.
> 
> Does this fix it?
> 
> virtio_net: Fix IP alignment on mergeable RX path
> 
> We need to enforce the IP alignment on the mergeable RX path just
> like the other RX path.  Not doing so results in misaligned IP
> headers.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

I'll apply this as soon as I see some test reports.

Has anyone had a chance to try this out yet?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html