netdev - Re: [PATCH] r8169: do not bring device down when suspending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090611.172257.90040273.davem@davemloft.net>
Date:	Thu, 11 Jun 2009 17:22:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	aeriksson@...tmail.fm, netdev@...r.kernel.org,
	edward_hsu@...ltek.com.tw
Subject: Re: [PATCH] r8169: do not bring device down when suspending

From: Francois Romieu <romieu@...zoreil.com>
Date: Thu, 11 Jun 2009 22:48:51 +0200

> Stopping all activity through ChipCmd and blindly acking the irqs
> is neither nice nor completely needed: the transition to low-power
> mode does enough work and it apparently keeps the device in a sane
> state.
> 
> Patch suggested by a fix for http://bugzilla.kernel.org/show_bug.cgi?id=9512
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Tested-by: Anders Eriksson <aeriksson@...tmail.fm>

This patch does not apply to net-next-2.6

You're patching rtl8169_suspend(), but in net-next-2.6 it does nothing
but call a function named rtl8169_net_suspend() which actually has the
code you seem to be changing.

Please submit a fixed up patch and let me know if you want me to queue
this up to -stable.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html