[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090612124028.fe4c2100.usui@mxm.nes.nec.co.jp>
Date: Fri, 12 Jun 2009 12:40:28 +0900
From: Minoru Usui <usui@....nes.nec.co.jp>
To: David Miller <davem@...emloft.net>
Cc: containers@...ts.linux-foundation.org, netdev@...r.kernel.org,
tgraf@...g.ch, hadi@...erus.ca, jarkao2@...il.com
Subject: Re: [PATCH 1/1] cls_cgroup: unify classid syntax to tc
Hi, David
Thank you for your comments.
On Thu, 11 Jun 2009 02:13:47 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:
> From: Minoru Usui <usui@....nes.nec.co.jp>
> Date: Thu, 11 Jun 2009 18:05:55 +0900
>
> > This patch unifies classid syntax of cls_cgroup to tc.
>
> Won't this break existing users?
>
> We really can't say "oh sorry" and change things after it's
> been effectively deployed already.
It's true. If my patch applied, old syntax can't use.
But I think compatibility is important, too.
So I'll make a new patch which can use both old and new syntax, when we write classid to net_cls.classid file.
Present implementation is an asymmetry with read and write.(read: decimal, write: hexadecimal)
I think this might be interface bug, so I think we should unify to read/write syntax.
Of course, if read syntax change from decimal expression, there isn't compatibility.
But I think it's better to fix this problem.
What do you think?
If it's ok, I'd like to be able to use tc syntax(X:Y style),
because cls_cgroup's purpose is select class which create by tc command.
tc command can only use classid syntax X:Y style, so we should be able to use X:Y style to cls_cgroup.
--
Minoru Usui <usui@....nes.nec.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists