netdev - Re: [Devel] Re: [PATCH 1/1] cls_cgroup: unify classid syntax to tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599ad830906112206n745fb0dw19cdb75d7c40b2a4@mail.gmail.com>
Date:	Thu, 11 Jun 2009 22:06:00 -0700
From:	Paul Menage <menage@...gle.com>
To:	Minoru Usui <usui@....nes.nec.co.jp>
Cc:	David Miller <davem@...emloft.net>, tgraf@...g.ch,
	netdev@...r.kernel.org, containers@...ts.linux-foundation.org,
	hadi@...erus.ca, jarkao2@...il.com
Subject: Re: [Devel] Re: [PATCH 1/1] cls_cgroup: unify classid syntax to tc

On Thu, Jun 11, 2009 at 8:40 PM, Minoru Usui<usui@....nes.nec.co.jp> wrote:
>
> It's true. If my patch applied, old syntax can't use.
> But I think compatibility is important, too.
> So I'll make a new patch which can use both old and new syntax, when we write classid to net_cls.classid file.
>
> Present implementation is an asymmetry with read and write.(read: decimal, write: hexadecimal)

You can write the classid value in decimal too, or even octal - it
just uses strtoull() to convert the string to an integer, so
0x-prefixed hex values are handled automatically.

>
> If it's ok, I'd like to be able to use tc syntax(X:Y style),
> because cls_cgroup's purpose is select class which create by tc command.
> tc command can only use classid syntax X:Y style, so we should be able to use X:Y style to cls_cgroup.

We should keep it as it is - purely apart from compatibility issues,
there's no need to introduce the complexity of the tc interface into
the cls_cgroup kernel code. When a cgroup control file represents a
simple integer, then it should be exposed as such.

Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html