netdev - Re: [RFC PATCH] Ethtool style in kernel network driver configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090612.170128.213931980.davem@davemloft.net>
Date:	Fri, 12 Jun 2009 17:01:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mfuzzey@...il.com
Cc:	bhutchings@...arflare.com, nico@....org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] Ethtool style in kernel network driver
 configuration.

From: Martin Fuzzey <mfuzzey@...il.com>
Date: Fri, 12 Jun 2009 14:19:11 +0200

> The smc9x driver contains this comment :
> /*
>  * The internal workings of the driver.  If you are changing anything
>  * here with the SMC stuff, you should have the datasheet and know
>  * what you are doing.
>  */
> Before writing this patch I had to disregard this to do the hacked version.
> I wasn't touching the driver to improve it or fix it - in which case
> it would be quite reasonable to expect me to have read the datasheet
> but just to turn off a bit of functionality to work around broken
> hardware.

I don't expect anyone to be required to read a data-sheet just to
prevent some link mode settings.

If the driver isn't clean enough to make a change like that easy,
that's a bug.

This is just a scarecrow argument.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html