netdev - Re: [PATCH] net: CNIC depends on PCI.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1245090298.12000.17.camel@HP1>
Date:	Mon, 15 Jun 2009 11:24:58 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Paul Mundt" <lethal@...ux-sh.org>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: CNIC depends on PCI.


On Mon, 2009-06-15 at 11:12 -0700, Paul Mundt wrote:
> Even though this driver does shifty things with UIO to make it less
> obvious, it is still PCI dependent:
> 
> drivers/net/cnic.c:2395: error: implicit declaration of function 'pci_dev_get'
> make[3]: *** [drivers/net/cnic.o] Error 1
> make[2]: *** [drivers/net] Error 2
> 
> This fixes up the CONFIG_PCI=n case, primarily triggered on
> allmodconfig/allyesconfig builds:
> 
> Signed-off-by: Paul Mundt <lethal@...ux-sh.org>
> Cc: Michael Chan <mchan@...adcom.com>

A similar patch is already in James' tree:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=babdb788f7ec1a782a52240a5f6dae568f32565f

> 
> ---
> 
>  drivers/net/Kconfig |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 3b63831..f6d6888 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2272,8 +2272,7 @@ config BNX2
>  
>  config CNIC
>  	tristate "Broadcom CNIC support"
> -	depends on BNX2
> -	depends on UIO
> +	depends on PCI && BNX2 && UIO
>  	help
>  	  This driver supports offload features of Broadcom NetXtremeII
>  	  gigabit Ethernet cards.
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html