netdev - Re: net: fix network drivers ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A376596.7020602@trash.net>
Date:	Tue, 16 Jun 2009 11:27:50 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>, perex@...ex.cz
Subject: Re: net: fix network drivers ndo_start_xmit() return values

Jarek Poplawski wrote:
>> --- a/drivers/net/wan/lapbether.c
>> +++ b/drivers/net/wan/lapbether.c
>> @@ -149,46 +149,42 @@ static int lapbeth_data_indication(struct net_device *dev, struct sk_buff *skb)
>>   */
>>  static int lapbeth_xmit(struct sk_buff *skb, struct net_device *dev)
>>  {
>> -	int err = -ENODEV;
>> +	int err;
>>  
>>  	/*
>>  	 * Just to be *really* sure not to send anything if the interface
>>  	 * is down, the ethernet device may have gone.
>>  	 */
>>  	if (!netif_running(dev)) {
>> +		// XXX

Oops, wrong diff :) Will resend in a minute.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html