netdev - Re: [PATCH] via-velocity : fix no link detection on boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090616205020.GB19349@electric-eye.fr.zoreil.com>
Date:	Tue, 16 Jun 2009 22:50:20 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Seguier Regis <rseguier@...eleport.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] via-velocity : fix no link detection on boot

Seguier Regis <rseguier@...eleport.net> :
[...]
> @@ -989,8 +989,11 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi
>  	if (ret < 0)
>  		goto err_iounmap;
>  
> -	if (velocity_get_link(dev))
> +	if (!velocity_get_link(dev))
> +	{
>  		netif_carrier_off(dev);

Ok but please do not put the curly brace on a proper line.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html