netdev - Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30 __list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A3A66CC.4090205@trash.net>
Date:	Thu, 18 Jun 2009 18:09:48 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, David Miller <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [bug] __nf_ct_refresh_acct(): WARNING: at lib/list_debug.c:30
 __list_add+0x7d/0xad()

Eric Dumazet wrote:
> In my own analysis, I found death_by_timeout() might be problematic,
> with RCU and lockless lookups.
> 
> static void death_by_timeout(unsigned long ul_conntrack)
> {
>         struct nf_conn *ct = (void *)ul_conntrack;
> 
>         if (!test_bit(IPS_DYING_BIT, &ct->status) &&
>             unlikely(nf_conntrack_event(IPCT_DESTROY, ct) < 0)) {
>                 /* destroy event was not delivered */
>                 nf_ct_delete_from_lists(ct);
> << HERE >>
> 
>                 nf_ct_insert_dying_list(ct);
>                 return;
>         }
>         set_bit(IPS_DYING_BIT, &ct->status);
>         nf_ct_delete_from_lists(ct);
>         nf_ct_put(ct);
> }
> 
> 
> We delete ct from a list and insert it in a new list.
> 
> I believe a reader could "*catch*" ct while doing a lookup and miss the end
> of its chain. (nulls algo check the null value at the end of lookup and can
> decide to restart the lookup if the null value is not the expected one)
> 
> We need to change nf_conntrack_init_net() and use a different "null" value,
> guaranteed not being used in regular lists

Good catch. This is a new bug, but it shouldn't matter in this case
since nf_conntrack_event() can't fail unless you have a userspace
listener that makes use of reliable delivery, which I think hasn't
even been released yet.

> Patch follows :

Looks good. If you send me a Signed-off-by: I'll already apply it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html