netdev - Re: [PATCH] Consolidate shared code between enic and fnic drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C65FC516.7747%scofeldm@cisco.com>
Date:	Thu, 18 Jun 2009 10:19:02 -0700
From:	Scott Feldman <scofeldm@...co.com>
To:	Mike Christie <michaelc@...wisc.edu>,
	Hannes Reinecke <hare@...e.de>
CC:	<James.Bottomley@...senPartnership.com>, <davem@...emloft.net>,
	<gospo@...hat.com>, <abjoglek@...co.com>, <jeykholt@...co.com>,
	<netdev@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] Consolidate shared code between enic and fnic drivers.

On 6/18/09 10:03 AM, "Mike Christie" <michaelc@...wisc.edu> wrote:

> Hannes Reinecke wrote:
>> Hmm. Seeing that we're getting more and more of these type of drivers
>> (cf bnx2 / bnx2i / cnic, enic / fnic, and at least one other in the pipe)
>> one does wonder whether we should establish a separate directory for
>> these kind of things.
>> drivers/virtual or drivers/shared springs to mind.
>> 
>> Having them in the network directory is probably not the
>> correct choice.
>> 
> 
> I think it might sometimes. I am not sure though. I think we have two
> models. One where this common/lib/helper/shim module requires a net
> driver/netdev and one where it does not.
> 
> I think vnic should go in a new dir. fnic does not require enic to
> interact with hardare. It only needs the vnic module and vnic module
> should not need the enic one. The fnic module does not interact with the
> network layer's net_device.

I wanted to break vnic out into a new dir, but I couldn't figure out where
this new dir lives.  I considered drivers/net/vnic, drivers/net/enic/vnic,
and drivers/vnic.  But none seemed right so I just left the vnic files in
the enic dir and built two modules there.  The fnic linkage is awkward, but
it works.  I like Hannes suggestion of drivers/shared/vnic (or
drivers/shared/cisco_vnic per Ben), especially if there are other drivers in
the tree that could use the drivers/shared dir today.

-scott

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html