netdev - Re: [RFC] skbuff: skb_mac_header_was

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090617.185301.172272524.davem@davemloft.net>
Date:	Wed, 17 Jun 2009 18:53:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	acme@...hat.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [RFC] skbuff: skb_mac_header_was_set is always true on >32 bit

From: Arnaldo Carvalho de Melo <acme@...hat.com>
Date: Wed, 17 Jun 2009 13:37:16 -0300

> Em Wed, Jun 17, 2009 at 08:23:27AM -0700, Stephen Hemminger escreveu:
>> Looking at the crash in log_martians(), one suspect is that the check for
>> mac header being set is not correct.  The value of mac_header defaults to
>> 0 on allocation, therefore skb_mac_header_was_set will always be true on
>> platforms using NET_SKBUFF_USES_OFFSET.
>> 
>> Arnaldo, is this correct?
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> Yeah, looks right, I forgot to initialize it to the value I changed the
> test in skb_mac_header_was_set when doing the offset patch :-\
> 
> Thanks!
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html