netdev - Re: [PATCH] mv643xx_eth: fix unicast filter programming in promiscuous mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090619.002508.239934377.davem@davemloft.net>
Date:	Fri, 19 Jun 2009 00:25:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	netdev@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] mv643xx_eth: fix unicast filter programming in
 promiscuous mode

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Thu, 18 Jun 2009 23:35:02 +0200

> From: Prabhanjan Sarnaik <sarnaik@...vell.com>
> 
> The Unicast Promiscious Mode (UPM) bit in the mv643xx_eth port
> configuration register doesn't do exactly what its name would suggest:
> setting this bit merely enables reception of all unicast frames with a
> destination address that differs from our local MAC address in bits
> [47:4].  In particular, it doesn't have any effect on unicast frames
> with a destination address that matches our MAC address in bits [47:4]
> -- these will still be tested against the 16-entry unicast address
> filter table.
> 
> Therefore, if the interface is set to promiscuous mode, just setting
> the unicast promiscuous bit isn't enough -- we need to set all filter
> bits in the unicast filter table to 1 as well.
> 
> Reported-by: Sachin Sanap <ssanap@...vell.com>
> Signed-off-by: Prabhanjan Sarnaik <sarnaik@...vell.com>
> Tested-by: Siddarth Gore <gores@...vell.com>
> Tested-by: Mahavir Jain <mjain@...vell.com>
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
> Cc: stable@...nel.org
> ---
> This patch is relevant for 2.6.29 and 2.6.30 as well.

Applied, and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html