netdev - Re: velocity driver unmaps incorrect size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090621.194248.72335974.davem@davemloft.net>
Date:	Sun, 21 Jun 2009 19:42:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	davej@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: velocity driver unmaps incorrect size.

From: Dave Jones <davej@...hat.com>
Date: Sun, 21 Jun 2009 22:40:44 -0400

> On Sun, Jun 21, 2009 at 06:43:45PM -0700, David Miller wrote:
> 
>  > Is it possible that for some reason
>  > your build is forcing VELOCITY_ZERO_COPY_SUPPORT to be defined
>  > for some reason?
> 
> Memory corruption maybe?
> It's especially odd in that it only happens once during boot,
> and never happens again. This is my firewall/router, so there's
> more packets going through that box than any other I have.

I would not be inclined to this theory.  Regardless of what garbage is
read from skb->len, it's always going to be at least ETH_ZLEN due to
the "max of skb->len and ETH_ZLEN" assignment there.

> btw, given the zerocopy stuff has been disabled for so long,
> is it worth keeping it ?

I'm pretty sure it should be tossed.  I wonder if anyone even tries
to build that code these days.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html