netdev - Re: [PATCH] ipv6: Use correct data types for ICMPv6 type and code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090623.043120.267458548.davem@davemloft.net>
Date:	Tue, 23 Jun 2009 04:31:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brian.haley@...com
Cc:	roel.kluin@...il.com, netdev@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] ipv6: Use correct data types for ICMPv6 type and code

From: Brian Haley <brian.haley@...com>
Date: Mon, 22 Jun 2009 12:20:54 -0400

> David Miller wrote:
>> From: Brian Haley <brian.haley@...com>
>> Date: Thu, 18 Jun 2009 00:09:36 -0400
>> 
>>> "type" is a u8 too, but both seem to be passed as int's everywhere (rawv6,
>>> tcp, sctp and dccp), and in the err_handler() func pointer in the inet6_protocol
>>> struct.  I can try and cook something up in the next few days that changes
>>> it all to u8's.
>> 
>> Feel free, thanks a lot.
> 
> I compile tested and made sure I could ping and get unreachables back up
> the TCP stack.  Also, applying Roel's original patch on top of this
> generated the expected compiler warning since it's always >= zero.
> 
> 
> Change all the code that deals directly with ICMPv6 type and code values
> to use u8 instead of a signed int as that's the actual data type.
> 
> Signed-off-by: Brian Haley <brian.haley@...com>

Thanks a lot for doing this work Brian, applied!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html