netdev - Re: [PATCH] Consolidate shared code between enic and fnic drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada8wjipt0d.fsf@cisco.com>
Date:	Tue, 23 Jun 2009 13:58:10 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Scott Feldman <scofeldm@...co.com>
Cc:	James.Bottomley@...senPartnership.com, davem@...emloft.net,
	michaelc@...wisc.edu, gospo@...hat.com, abjoglek@...co.com,
	jeykholt@...co.com, netdev@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH] Consolidate shared code between enic and fnic drivers.


 > The Cisco enic 10G Ethernet driver and the fnic FCoE HBA driver share
 > much of the same hardware-access code because enic and fnic devices are
 > really two functions on a converged-I/O PCIe device.  This patch
 > consolidates the shared code into one shared module, thus eliminating
 > the code duplication.  No functional changes are made by the patch.

Big ACK on this from me -- I never liked duplicating all this code
between the two drivers.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html