netdev - Re: [PATCH] can: let SJA1000 driver depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A41E91F.1020509@grandegger.com>
Date:	Wed, 24 Jun 2009 10:51:43 +0200
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Oliver Hartkopp <socketcan@...tkopp.net>
CC:	David Miller <davem@...emloft.net>, heiko.carstens@...ibm.com,
	schwidefsky@...ibm.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM

Oliver Hartkopp wrote:
> Wolfgang Grandegger wrote:
>> David Miller wrote:
>>> From: Oliver Hartkopp <socketcan@...tkopp.net>
> 
>>>> the question is, if we should add HAS_IOMEM to almost every SJA1000 depended
>>>> driver like SJA1000_PLATFORM, SJA1000_OF_PLATFORM, EMS_PCI and KVASER_PCI ???
>>>>
>>>> Is it possible to have a support for the SJA1000 that does *not* depend on
>>>> HAS_IOMEM?
>> In principle yes by using an appropriate driver accessing the SJA1000
>> with other methods. But I might be wrong because it does not make sense
>> hardware-wise.
>>
>>> This was my initial impression when I saw Wolfgang's suggested patch,
>>> and I still feel this way, and thus Heiko's patch seems the best for
>>> now until there is an exception.
>>>
>>> And in fact Heiko's patch has been in my tree for a while already :)
>> OK, that's fine for the moment. We may even consider making CONFIG_CAN
>> depend on HAS_IOMEM like for SPI, USB, Serial, etc.
> 
> Why CONFIG_CAN ??
> 
> CONFIG_CAN provides a network protocol family that can be used e.g. with the
> vcan driver without any hardware. So HAS_IOMEM only has to take care of some
> drivers, that fiddle on CAN controller registers themselves. E.g. for SPI, USB
> and Serial these 'underlying' interfaces bring their own requirements. When we
> depend on SPI, it should bring HAS_IOMEM as a dependency of SPI.

OK, then s/CONFIG_CAN/CONFIG_CAN_DEV/

Wolfgang.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html