netdev - Re: [2.6.30-git21] Network Namespace test failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090625.024914.114440252.davem@davemloft.net>
Date:	Thu, 25 Jun 2009 02:49:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	serue@...ibm.com
Cc:	sachinp@...ibm.com, netdev@...r.kernel.org,
	serue@...ux.vnet.ibm.com, matthltc@...ibm.com,
	shemminger@...tta.com
Subject: Re: [2.6.30-git21] Network Namespace test failure

From: "Serge E. Hallyn" <serue@...ibm.com>
Date: Wed, 24 Jun 2009 22:38:47 -0500

>>>From 7193023ad09dbc4b57909c0204c19ed93472cd9e Mon Sep 17 00:00:00 2001
> From: root <root@...3b203.beaverton.ibm.com>
> Date: Wed, 24 Jun 2009 20:26:17 -0700
> Subject: [PATCH 1/1] veth: don't free priv->status until dev->destructor
> 
> Since commit ae0e8e82205c903978a79ebf5e31c670b61fa5b4, priv->status
> has been freed at veth_close().  But that causes a NULL deref at
> veth_xmit.  This patch moves priv->status free back to the device
> destructor.
> 
> Signed-off-by: Serge Hallyn <serue@...ibm.com>

I think ae0e8e82205c903978a79ebf5e31c670b61fa5b4 is worse than
the problem it's trying to cure.  It introduces two regressions:

1) This OOPS we are discussing.

2) statistics are not "remembered" across ifdown/ifup and that
   disagrees with how every other network device works

I'm going to revert that change, and the dev->destructor pointing
to module code problem will need to be fixed in another way.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html