netdev - Re: [PATCH] net: fix race in the receive/select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090626.111738.141246987.davem@davemloft.net>
Date:	Fri, 26 Jun 2009 11:17:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	davidel@...ilserver.org
Cc:	oleg@...hat.com, eric.dumazet@...il.com, jolsa@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	fbl@...hat.com, nhorman@...hat.com, htejun@...il.com
Subject: Re: [PATCH] net: fix race in the receive/select

From: Davide Libenzi <davidel@...ilserver.org>
Date: Fri, 26 Jun 2009 11:12:15 -0700 (PDT)

> On Fri, 26 Jun 2009, Oleg Nesterov wrote:
> 
>> Perhaps we can add
>> 
>> 	void sock_poll_wait(struct file *file, struct sock *sk, poll_table *pt)
>> 	{
>> 		if (pt) {
>> 			poll_wait(file, sk->sk_sleep, pt);
>> 			/*
>> 			 * fat comment
>> 			 */
>> 			smp_mb(); // or smp_mb__after_unlock();
>> 		}
>> 	}
> 
> That'd be fine IMHO. Are DaveM and Eric OK?

No objections from me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html