netdev - Re: [PATCH] sctp: xmit sctp packet always return no route error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A48BDD6.1020001@hp.com>
Date:	Mon, 29 Jun 2009 09:12:54 -0400
From:	Vlad Yasevich <vladislav.yasevich@...com>
To:	Wei Yongjun <yjwei@...fujitsu.com>
CC:	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Netdev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org
Subject: Re: [PATCH] sctp: xmit sctp packet always return no route error

Wei Yongjun wrote:
> Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
> broken the sctp protocol stack, the sctp packet can never be sent out after
> Eric Dumazet's patch, which have typo in the sctp code.
> 
> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>

Oh-oh!!  Thanks for catching this.

Acked-by: Vlad Yasevich <vladisalv.yasevich@...com>

-vlad

> ---
>  net/sctp/output.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sctp/output.c b/net/sctp/output.c
> index b764114..b94c211 100644
> --- a/net/sctp/output.c
> +++ b/net/sctp/output.c
> @@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
>  	}
>  	dst = dst_clone(tp->dst);
>  	skb_dst_set(nskb, dst);
> -	if (dst)
> +	if (!dst)
>  		goto no_route;
>  
>  	/* Build the SCTP header.  */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html