netdev - Re: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090630.124619.163112912.davem@davemloft.net>
Date:	Tue, 30 Jun 2009 12:46:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	nooiwa@...aclelinux.com, mchan@...adcom.com, rick.jones2@...com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bnx2: Fix the behavior of ethtool when ONBOOT=no

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Tue, 30 Jun 2009 17:50:16 +0300

> On Sun, 2009-06-28 at 17:49 -0700, Naohiro Ooiwa wrote:
>> Hi Michael
>> 
>> Thank you for your comment.
>> 
>> I tried to create a patch of bnx2x driver.
>> It's the same fix as bnx2 driver.
>> Could you please check the my patch ?
>> 
>> Of cource, I made sure of compile.
> 
> It is also working as expected. I already made a similar patch based on
> your bnx2 fix and it looks exactly the same...
> 
> Thanks!
> 
>> 
>> Signed-off-by: Naohiro Ooiwa <nooiwa@...aclelinux.com>
> Acked-by: Eilon Greenstein <eilong@...adcom.com>

Applied, but you really need to begin writing proper changelog
entries when you send patches out.  Here is the one I wrote for you
below.  Otherwise a random person looking at this change will have no
idea the reason for it, nor what it is related to.

==================================================
bnx2x: Fix the behavior of ethtool when ONBOOT=no

This is the same fix as commit
7959ea254ed18faee41160b1c50b3c9664735967 ("bnx2: Fix the behavior of
ethtool when ONBOOT=no"), but for bnx2x:

--------------------
    When configure in ifcfg-eth* is ONBOOT=no,
    the behavior of ethtool command is wrong.
    
        # grep ONBOOT /etc/sysconfig/network-scripts/ifcfg-eth2
        ONBOOT=no
        # ethtool eth2 | tail -n1
                Link detected: yes
    
    I think "Link detected" should be "no".
--------------------

Signed-off-by: Naohiro Ooiwa <nooiwa@...aclelinux.com>
Acked-by: Eilon Greenstein <eilong@...adcom.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html