netdev - Re: forcedeth skb_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090629.194325.224550663.davem@davemloft.net>
Date:	Mon, 29 Jun 2009 19:43:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	johannes@...solutions.net, netdev@...r.kernel.org
Subject: Re: forcedeth skb_gso_segment warning

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Mon, 29 Jun 2009 12:06:41 +0800

> On Mon, Jun 29, 2009 at 12:03:30PM +0800, Herbert Xu wrote:
>> 
>> tcp: Stop non-TSO packets morphing into TSO
> 
> Here's a follow-up patch to optimise this boundary case.
> 
> tcp: Do not tack on TSO data to non-TSO packet
> 
> If a socket starts out on a non-TSO route, and then switches to
> a TSO route, then we will tack on data to the tail of the tx queue
> even if it started out life as non-TSO.  This is suboptimal because
> all of it will then be copied and checksummed unnecessarily.
> 
> This patch fixes this by ensuring that skb->ip_summed is set to
> CHECKSUM_PARTIAL before appending extra data beyond the MSS.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html