netdev - Re: [PATCH] phylib: fixes for PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3253A2AC-9D19-4B02-8526-0D460C6E409E@freescale.com>
Date:	Wed, 1 Jul 2009 19:34:24 -0500
From:	Andy Fleming <afleming@...escale.com>
To:	Wade Farnsworth <wfarnsworth@...sta.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] phylib: fixes for PHY_RESUMING state changes


On Jul 1, 2009, at 6:00 PM, Wade Farnsworth wrote:

> The PHY_HALTED state disables phydev->link, but the link will not be
> updated upon entering PHY_RESUMING.  Add a call to phy_read_status()  
> to
> update the link before entering PHY_RUNNING.  If the link is not up at
> this point, enter the PHY_NOLINK state instead.
>
> Also, when transitioning from PHY_RESUMING to PHY_RUNNING, calls to
> netif_carrier_on() and phydev->adjust_link() are missing.  Add the  
> calls
> similar to the other transitions to PHY_RUNNING.
>
> Signed-off-by: Wade Farnsworth <wfarnsworth@...sta.com>

Acked-by: Andy Fleming <afleming@...escale.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html