netdev - Re: [PATCH 1/2] xfrm4: fix the ports decode of sctp protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090703034849.GA23183@gondor.apana.org.au>
Date:	Fri, 3 Jul 2009 11:48:49 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Wei Yongjun <yjwei@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Vlad Yasevich <vladislav.yasevich@...com>
Subject: Re: [PATCH 1/2] xfrm4: fix the ports decode of sctp protocol

On Fri, Jul 03, 2009 at 10:57:23AM +0800, Wei Yongjun wrote:
> The SCTP pushed the skb data above the sctp chunk header, so the check
> of pskb_may_pull(skb, xprth + 4 - skb->data) in _decode_session4() will
> never return 0 because xprth + 4 - skb->data < 0, the ports decode of
> sctp will always fail.
> 
> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>

Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Longer term I wonder if we can move this stuff into the protocol
code, i.e., before they call xfrm_policy_check.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html